Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: exception and error middleware #2590

Merged
merged 1 commit into from
Jul 9, 2024
Merged

feat: exception and error middleware #2590

merged 1 commit into from
Jul 9, 2024

Conversation

zzzming
Copy link
Collaborator

@zzzming zzzming commented Jul 8, 2024

An exception and error FastAPI middleware that replies the more detailed error message back the client.
This is a step to enable meaningful error messages for the UI or client

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 8, 2024
@zzzming zzzming requested a review from ogabrielluiz July 8, 2024 19:22
@dosubot dosubot bot added the enhancement New feature or request label Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored ✅ ❌
Pull request is made by a whitelisted user and should be ignored ❌ ❌
Pull request is submitted by a bot and should be ignored ✅ ❌
Pull request is submitted by administrators and should be ignored ❌ ❌

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages ❌ ✅
Pull request does not introduce too many changes ❌ ✅
Pull request has a valid title ✅ ✅
Pull request has mentioned issues ❌ ✅
Pull request has valid branch name ❌ ✅
Pull request should have a non-empty body ✅ ✅

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 08 Jul 24 19:23 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 8, 2024
nicoloboschi
nicoloboschi approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 9, 2024
nicoloboschi
nicoloboschi reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does impact the frontend error handling when calling the backend. We need to ensure everything is covered as expected

mfortman11
mfortman11 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@mfortman11 mfortman11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogabrielluiz ogabrielluiz merged commit ce9b4b0 into main Jul 9, 2024
29 checks passed
@ogabrielluiz ogabrielluiz deleted the feat/except-middleware branch July 9, 2024 13:13
ogabrielluiz pushed a commit to yaitec/langflow that referenced this pull request Jul 9, 2024
@zzzming @ogabrielluiz
feat: exception and error middleware (langflow-ai#2590)
49aea91 
exception and error middleware
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 10, 2024
@zzzming @nicoloboschi
feat: exception and error middleware (langflow-ai#2590)
149203f 
exception and error middleware

(cherry picked from commit ce9b4b0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@mfortman11 mfortman11 mfortman11 approved these changes

@ogabrielluiz ogabrielluiz Awaiting requested review from ogabrielluiz

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zzzming @mfortman11 @nicoloboschi @ogabrielluiz